Conversation
- Remove 109 lines of outdated commented-out quickSelect implementation from Array.fs (superseded by the current Lomuto-partition version) - Add <RepositoryBranch>developer</RepositoryBranch> to FSharp.Stats.fsproj so that FsDoc source links point to the correct 'developer' branch instead of defaulting to 'main' (fixes ApiDocs wrong branch links, #338) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bvenn
approved these changes
Mar 27, 2026
bvenn
deleted the
repo-assist/improve-dead-code-and-apidocs-branch-fix-4b2037de57734b05
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Summary
Two small, low-risk coding improvements:
1. Remove 109 lines of outdated commented-out code from
Array.fsThe file contained an entire old
partitionSortInPlace/quickSelect/quickSelectInPlaceimplementation that was superseded by the current Lomuto-partition-based version. It was marked with a comment "Old partitionSortInPlace fails with duplicates" and every line was commented out. This dead code:2. Add
(RepositoryBranch)developer(/RepositoryBranch)toFSharp.Stats.fsprojFsDoc uses the
RepositoryBranchMSBuild property to construct "view source" links in the generated API docs. Without it, FsDoc falls back to the repository default branch (main), so all source links in the docs pointed tomainrather thandeveloper— meaning the linked code often didn't match the released docs.Closes #338
Test Status
✅ Build: succeeded (0 errors, pre-existing warnings only)
✅ Tests: 1191/1191 passed